Messages in this thread | | | Date | Tue, 14 Jun 2022 19:30:20 +0100 | Subject | Re: [PATCH RFC v2 01/18] blk-mq: Add a flag for reserved requests | From | John Garry <> |
| |
On 14/06/2022 19:00, Bart Van Assche wrote: > On 6/9/22 03:29, John Garry wrote: >> Add a flag for reserved requests so that drivers may know this for any >> special handling. >> >> The 'reserved' argument in blk_mq_ops.timeout callback could now be >> replaced by using this flag. > > Why not to combine that change into this patch? >
If we remove the 'reserved' argument in blk_mq_ops.timeout callback then we can also remove the 'reserved' member of busy_tag_iter_fn. I gave that all a try and the diffstat looks like this:
block/blk-mq-debugfs.c | 2 +- block/blk-mq-tag.c | 13 +++++-------- block/blk-mq.c | 22 +++++++++++++--------- block/bsg-lib.c | 2 +- drivers/block/mtip32xx/mtip32xx.c | 11 +++++------ drivers/block/nbd.c | 5 ++--- drivers/block/null_blk/main.c | 2 +- drivers/infiniband/ulp/srp/ib_srp.c | 3 +-- drivers/mmc/core/queue.c | 3 +-- drivers/nvme/host/apple.c | 3 +-- drivers/nvme/host/core.c | 2 +- drivers/nvme/host/fc.c | 6 ++---- drivers/nvme/host/nvme.h | 2 +- drivers/nvme/host/pci.c | 2 +- drivers/nvme/host/rdma.c | 3 +-- drivers/nvme/host/tcp.c | 3 +-- drivers/s390/block/dasd.c | 2 +- drivers/scsi/aacraid/comminit.c | 2 +- drivers/scsi/aacraid/linit.c | 2 +- drivers/scsi/hosts.c | 14 ++++++-------- drivers/scsi/mpi3mr/mpi3mr_os.c | 15 ++++----------- drivers/scsi/scsi_lib.c | 12 ++---------- include/linux/blk-mq.h | 10 ++++++++-- include/scsi/scsi_host.h | 2 +- 24 files changed, 62 insertions(+), 81 deletions(-)
It would seem sensible to send that all separately and break it down a bit - this series is already almost unmanageable.
> Anyway: > > Reviewed-by: Bart Van Assche <bvanassche@acm.org> > .
Thanks
| |