lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 093/411] drm: mali-dp: potential dereference of null pointer
    Date
    From: Jiasheng Jiang <jiasheng@iscas.ac.cn>

    [ Upstream commit 73c3ed7495c67b8fbdc31cf58e6ca8757df31a33 ]

    The return value of kzalloc() needs to be checked.
    To avoid use of null pointer '&state->base' in case of the
    failure of alloc.

    Fixes: 99665d072183 ("drm: mali-dp: add malidp_crtc_state struct")
    Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    Reviewed-by: Brian Starkey <brian.starkey@arm.com>
    Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20211214100837.46912-1-jiasheng@iscas.ac.cn
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/arm/malidp_crtc.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c
    index 587d94798f5c..af729094260c 100644
    --- a/drivers/gpu/drm/arm/malidp_crtc.c
    +++ b/drivers/gpu/drm/arm/malidp_crtc.c
    @@ -483,7 +483,10 @@ static void malidp_crtc_reset(struct drm_crtc *crtc)
    if (crtc->state)
    malidp_crtc_destroy_state(crtc, crtc->state);

    - __drm_atomic_helper_crtc_reset(crtc, &state->base);
    + if (state)
    + __drm_atomic_helper_crtc_reset(crtc, &state->base);
    + else
    + __drm_atomic_helper_crtc_reset(crtc, NULL);
    }

    static int malidp_crtc_enable_vblank(struct drm_crtc *crtc)
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 13:13    [W:3.581 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site