lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 159/218] net: dsa: mv88e6xxx: Fix refcount leak in mv88e6xxx_mdios_register
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 02ded5a173619b11728b8bf75a3fd995a2c1ff28 ]

    of_get_child_by_name() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when done.

    mv88e6xxx_mdio_register() pass the device node to of_mdiobus_register().
    We don't need the device node after it.

    Add missing of_node_put() to avoid refcount leak.

    Fixes: a3c53be55c95 ("net: dsa: mv88e6xxx: Support multiple MDIO busses")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Marek Behún <kabel@kernel.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/dsa/mv88e6xxx/chip.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
    index 7ab4cc0962ac..ef016c9f7c74 100644
    --- a/drivers/net/dsa/mv88e6xxx/chip.c
    +++ b/drivers/net/dsa/mv88e6xxx/chip.c
    @@ -2317,6 +2317,7 @@ static int mv88e6xxx_mdios_register(struct mv88e6xxx_chip *chip,
    */
    child = of_get_child_by_name(np, "mdio");
    err = mv88e6xxx_mdio_register(chip, child, false);
    + of_node_put(child);
    if (err)
    return err;

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 13:02    [W:4.058 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site