lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 142/218] tty: goldfish: Use tty_port_destroy() to destroy port
    Date
    From: Wang Weiyang <wangweiyang2@huawei.com>

    [ Upstream commit 507b05063d1b7a1fcb9f7d7c47586fc4f3508f98 ]

    In goldfish_tty_probe(), the port initialized through tty_port_init()
    should be destroyed in error paths.In goldfish_tty_remove(), qtty->port
    also should be destroyed or else might leak resources.

    Fix the above by calling tty_port_destroy().

    Fixes: 666b7793d4bf ("goldfish: tty driver")
    Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
    Signed-off-by: Wang Weiyang <wangweiyang2@huawei.com>
    Link: https://lore.kernel.org/r/20220328115844.86032-1-wangweiyang2@huawei.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/goldfish.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c
    index 85a500ddbcaa..1b72321f2d0b 100644
    --- a/drivers/tty/goldfish.c
    +++ b/drivers/tty/goldfish.c
    @@ -414,6 +414,7 @@ static int goldfish_tty_probe(struct platform_device *pdev)
    err_tty_register_device_failed:
    free_irq(irq, qtty);
    err_dec_line_count:
    + tty_port_destroy(&qtty->port);
    goldfish_tty_current_line_count--;
    if (goldfish_tty_current_line_count == 0)
    goldfish_tty_delete_driver();
    @@ -435,6 +436,7 @@ static int goldfish_tty_remove(struct platform_device *pdev)
    iounmap(qtty->base);
    qtty->base = NULL;
    free_irq(qtty->irq, pdev);
    + tty_port_destroy(&qtty->port);
    goldfish_tty_current_line_count--;
    if (goldfish_tty_current_line_count == 0)
    goldfish_tty_delete_driver();
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 13:00    [W:4.197 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site