lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 095/218] powerpc/fsl_rio: Fix refcount leak in fsl_rio_setup
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit fcee96924ba1596ca80a6770b2567ca546f9a482 ]

    of_parse_phandle() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: abc3aeae3aaa ("fsl-rio: Add two ports and rapidio message units support")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20220512123724.62931-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/sysdev/fsl_rio.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c
    index 5011ffea4e4b..c48ebe677962 100644
    --- a/arch/powerpc/sysdev/fsl_rio.c
    +++ b/arch/powerpc/sysdev/fsl_rio.c
    @@ -509,8 +509,10 @@ int fsl_rio_setup(struct platform_device *dev)
    if (rc) {
    dev_err(&dev->dev, "Can't get %pOF property 'reg'\n",
    rmu_node);
    + of_node_put(rmu_node);
    goto err_rmu;
    }
    + of_node_put(rmu_node);
    rmu_regs_win = ioremap(rmu_regs.start, resource_size(&rmu_regs));
    if (!rmu_regs_win) {
    dev_err(&dev->dev, "Unable to map rmu register window\n");
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 12:52    [W:3.740 / U:0.956 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site