Messages in this thread | | | Date | Tue, 14 Jun 2022 10:48:06 +0800 | From | kernel test robot <> | Subject | Re: [PATCH 1/2] security: Add LSM hook to setgroups() syscall |
| |
Hi Micah,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on jmorris-security/next-testing kees/for-next/pstore v5.19-rc2 next-20220610] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Micah-Morton/security-Add-LSM-hook-to-setgroups-syscall/20220614-050341 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3 config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220614/202206141053.xW4ze6oP-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/b21cba6f759a2a60439de4d0f85323ed745b3ade git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Micah-Morton/security-Add-LSM-hook-to-setgroups-syscall/20220614-050341 git checkout b21cba6f759a2a60439de4d0f85323ed745b3ade # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
kernel/groups.c: In function 'set_current_groups': >> kernel/groups.c:143:13: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 143 | old = current_cred(); | ^ >> kernel/groups.c:147:9: error: 'retval' undeclared (first use in this function) 147 | retval = security_task_fix_setgroups(new, old); | ^~~~~~ kernel/groups.c:147:9: note: each undeclared identifier is reported only once for each function it appears in
vim +/retval +147 kernel/groups.c
126 127 /** 128 * set_current_groups - Change current's group subscription 129 * @group_info: The group list to impose 130 * 131 * Validate a group subscription and, if valid, impose it upon current's task 132 * security record. 133 */ 134 int set_current_groups(struct group_info *group_info) 135 { 136 struct cred *new; 137 struct cred *old; 138 139 new = prepare_creds(); 140 if (!new) 141 return -ENOMEM; 142 > 143 old = current_cred(); 144 145 set_groups(new, group_info); 146 > 147 retval = security_task_fix_setgroups(new, old); 148 if (retval < 0) 149 goto error; 150 151 return commit_creds(new); 152 153 error: 154 abort_creds(new); 155 return retval; 156 } 157
-- 0-DAY CI Kernel Test Service https://01.org/lkp
| |