Messages in this thread | | | From | Lai Jiangshan <> | Date | Tue, 14 Jun 2022 10:20:17 +0800 | Subject | Re: [PATCH 3/8] KVM: x86/mmu: Bury 32-bit PSE paging helpers in paging_tmpl.h |
| |
On Tue, Jun 14, 2022 at 6:59 AM Sean Christopherson <seanjc@google.com> wrote: > > Move a handful of one-off macros and helpers for 32-bit PSE paging into > paging_tmpl.h and hide them behind "PTTYPE == 32". Under no circumstance > should anything but 32-bit shadow paging care about PSE paging. >
Moving code from paging_tmp.h is on my to-do list. I don't think the opposite direction is preferred.
And is_cpuid_PSE36() is also used in mmu.c, is it a good idea to move it into paging_tmp.h?
| |