lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 20/29] scsi: pmcraid: Fix missing resource cleanup in error case
    Date
    From: Chengguang Xu <cgxu519@mykernel.net>

    [ Upstream commit ec1e8adcbdf661c57c395bca342945f4f815add7 ]

    Fix missing resource cleanup (when '(--i) == 0') for error case in
    pmcraid_register_interrupt_handler().

    Link: https://lore.kernel.org/r/20220529153456.4183738-6-cgxu519@mykernel.net
    Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/pmcraid.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
    index cbe5fab793eb..ce10d680c56c 100644
    --- a/drivers/scsi/pmcraid.c
    +++ b/drivers/scsi/pmcraid.c
    @@ -4528,7 +4528,7 @@ pmcraid_register_interrupt_handler(struct pmcraid_instance *pinstance)
    return 0;

    out_unwind:
    - while (--i > 0)
    + while (--i >= 0)
    free_irq(pci_irq_vector(pdev, i), &pinstance->hrrq_vector[i]);
    pci_free_irq_vectors(pdev);
    return rc;
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-06-14 04:21    [W:4.287 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site