lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.15 18/41] ASoC: wm_adsp: Fix event generation for wm_adsp_fw_put()
    Date
    From: Mark Brown <broonie@kernel.org>

    [ Upstream commit 2abdf9f80019e8244d3806ed0e1c9f725e50b452 ]

    Currently wm_adsp_fw_put() returns 0 rather than 1 when updating the value
    of the control, meaning that no event is generated to userspace. Fix this
    by setting the default return value to 1, the code already exits early with
    a return value of 0 if the value is unchanged.

    Signed-off-by: Mark Brown <broonie@kernel.org>
    Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
    Link: https://lore.kernel.org/r/20220603115003.3865834-1-broonie@kernel.org
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/wm_adsp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
    index f7c800927cb2..08fc1a025b1a 100644
    --- a/sound/soc/codecs/wm_adsp.c
    +++ b/sound/soc/codecs/wm_adsp.c
    @@ -794,7 +794,7 @@ int wm_adsp_fw_put(struct snd_kcontrol *kcontrol,
    struct snd_soc_component *component = snd_soc_kcontrol_component(kcontrol);
    struct soc_enum *e = (struct soc_enum *)kcontrol->private_value;
    struct wm_adsp *dsp = snd_soc_component_get_drvdata(component);
    - int ret = 0;
    + int ret = 1;

    if (ucontrol->value.enumerated.item[0] == dsp[e->shift_l].fw)
    return 0;
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-06-14 04:16    [W:4.199 / U:0.648 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site