Messages in this thread | | | Date | Tue, 14 Jun 2022 09:48:17 +0800 | Subject | Re: [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl | From | Chao Yu <> |
| |
On 2022/6/14 1:23, Jonathan Corbet wrote: > Chao Liu <chaoliu719@gmail.com> writes: > >> On Mon, Jun 13, 2022 at 04:37:01AM +0100, Matthew Wilcox wrote: >>> On Mon, Jun 13, 2022 at 10:08:00AM +0800, Chao Liu wrote: >>>> v2: >>>> - s/file size/filesize/ >>> >>> Why would you change it to be wrong? >>> >> >> This is a suggestion from Chao Yu. Maybe he has some other considerations. > > Sorry, I should have replied to that. I disagree with that suggestion. > "Filesize" is not an English word, and there doesn't seem to be any > reason to use it in our docs.
My bad, out of mind at that time, sorry for my wrong suggestion...
> > <checks> > > We have to occurrences now - one already in the f2fs docs. I think we > shouldn't add more. So my plan is to apply the first version of this > patch. Chao Liu: is there a reason why you didn't add the Reviewed-by > from Chao Yu in the second version? Chao Yu: is that tag still > applicable even without the "filesize" change?
Yes.
Thanks,
> > Thanks, > > jon
| |