Messages in this thread | | | From | David Howells <> | Subject | Re: mainline build failure due to 6c77676645ad ("iov_iter: Fix iter_xarray_get_pages{,_alloc}()") | Date | Mon, 13 Jun 2022 10:19:18 +0100 |
| |
Al Viro <viro@zeniv.linux.org.uk> wrote:
> The reason we can't overflow on multiplication there, BTW, is that we have > nr <= count, and count has come from weirdly open-coded > DIV_ROUND_UP(size + offset, PAGE_SIZE) > IMO we'd better make it explicit, so how about the following: > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
It seems reasonable.
Reviewed-by: David Howells <dhowells@redhat.com>
| |