Messages in this thread | | | Date | Mon, 13 Jun 2022 14:22:23 -0600 | From | Rob Herring <> | Subject | Re: [PATCH v4 10/18] PCI: dwc: Convert Link-up status method to using dw_pcie_readl_dbi() |
| |
On Fri, Jun 10, 2022 at 11:25:26AM +0300, Serge Semin wrote: > While the rest of the generic DWC PCIe code is using the dedicated IO-mem > accessors, the dw_pcie_link_up() method for some unobvious reason directly > calls readl() to get PortLogic.DEBUG1 register content. Since the way the > dbi-bus is accessed can be platform-specific let's replace the direct dbi > memory space read procedure with the readl-wrapper invocation. Thus we'll > have a slightly more generic dw_pcie_link_up() method. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > drivers/pci/controller/dwc/pcie-designware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Rob Herring <robh@kernel.org>
| |