lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 03/18] PCI: dwc: Disable outbound windows for controllers with iATU
    On Fri, Jun 10, 2022 at 11:25:19AM +0300, Serge Semin wrote:
    > In accordance with the dw_pcie_setup_rc() method semantics and judging by
    > what the comment added in commit dd193929d91e ("PCI: designware: Explain
    > why we don't program ATU for some platforms") states there are DWC
    > PCIe-available platforms like Keystone (pci-keystone.c) or Amazon's
    > Annapurna Labs (pcie-al.c) which don't have the DW PCIe internal ATU
    > enabled and use it's own address translation approach implemented. In
    > these cases at the very least there is no point in touching the DW PCIe
    > iATU CSRs. Moreover depending on the vendor-specific address translation
    > implementation it might be even erroneous. So let's move the iATU windows
    > disabling procedure to being under the corresponding conditional statement
    > clause thus performing that procedure only if the iATU is expected to be
    > available on the platform.
    >
    > Fixes: 458ad06c4cdd ("PCI: dwc: Ensure all outbound ATU windows are reset")
    > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
    > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    > Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    > ---
    > drivers/pci/controller/dwc/pcie-designware-host.c | 14 ++++++++------
    > 1 file changed, 8 insertions(+), 6 deletions(-)

    Reviewed-by: Rob Herring <robh@kernel.org>

    \
     
     \ /
      Last update: 2022-06-13 23:00    [W:4.596 / U:0.924 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site