lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 06/16] ACPI: container: Use acpi_dev_for_each_child()
    Date
    From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

    Instead of walking the list of children of an ACPI device directly,
    use acpi_dev_for_each_child() to carry out an action for all of
    the given ACPI device's children.

    This will help to eliminate the children list head from struct
    acpi_device as it is redundant and it is used in questionable ways
    in some places (in particular, locking is needed for walking the
    list pointed to it safely, but it is often missing).

    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---

    v1 -> v2:
    * Do not break the acpi_dev_for_each_child() call line (Andy).
    * Add R-by from Andy.

    ---
    drivers/acpi/container.c | 17 +++++++++--------
    1 file changed, 9 insertions(+), 8 deletions(-)

    Index: linux-pm/drivers/acpi/container.c
    ===================================================================
    --- linux-pm.orig/drivers/acpi/container.c
    +++ linux-pm/drivers/acpi/container.c
    @@ -23,17 +23,18 @@ static const struct acpi_device_id conta

    #ifdef CONFIG_ACPI_CONTAINER

    -static int acpi_container_offline(struct container_dev *cdev)
    +static int check_offline(struct acpi_device *adev, void *not_used)
    {
    - struct acpi_device *adev = ACPI_COMPANION(&cdev->dev);
    - struct acpi_device *child;
    + if (acpi_scan_is_offline(adev, false))
    + return 0;

    - /* Check all of the dependent devices' physical companions. */
    - list_for_each_entry(child, &adev->children, node)
    - if (!acpi_scan_is_offline(child, false))
    - return -EBUSY;
    + return -EBUSY;
    +}

    - return 0;
    +static int acpi_container_offline(struct container_dev *cdev)
    +{
    + /* Check all of the dependent devices' physical companions. */
    + return acpi_dev_for_each_child(ACPI_COMPANION(&cdev->dev), check_offline, NULL);
    }

    static void acpi_container_release(struct device *dev)


    \
     
     \ /
      Last update: 2022-06-13 22:07    [W:4.144 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site