lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl
Date
Chao Liu <chaoliu719@gmail.com> writes:

> On Mon, Jun 13, 2022 at 04:37:01AM +0100, Matthew Wilcox wrote:
>> On Mon, Jun 13, 2022 at 10:08:00AM +0800, Chao Liu wrote:
>> > v2:
>> > - s/file size/filesize/
>>
>> Why would you change it to be wrong?
>>
>
> This is a suggestion from Chao Yu. Maybe he has some other considerations.

Sorry, I should have replied to that. I disagree with that suggestion.
"Filesize" is not an English word, and there doesn't seem to be any
reason to use it in our docs.

<checks>

We have to occurrences now - one already in the f2fs docs. I think we
shouldn't add more. So my plan is to apply the first version of this
patch. Chao Liu: is there a reason why you didn't add the Reviewed-by
from Chao Yu in the second version? Chao Yu: is that tag still
applicable even without the "filesize" change?

Thanks,

jon

\
 
 \ /
  Last update: 2022-06-13 21:23    [W:1.383 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site