lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mm: Remove unwanted initialization in vmemmap_populate_compound_pages()
From
On 12.06.22 20:23, Gautam Menghani wrote:
> Remove unwanted initialization for the variable 'next'. This fixes the
> clang scan warning: Value stored to 'next' during its initialization is
> never read [deadcode.DeadStores]
>

Nit: s/unwanted/unnecessary/

Reviewed-by: David Hildenbrand <david@redhat.com>

> Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
> ---
> mm/sparse-vmemmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c
> index f4fa61dbbee3..3008aa7859e0 100644
> --- a/mm/sparse-vmemmap.c
> +++ b/mm/sparse-vmemmap.c
> @@ -737,7 +737,7 @@ static int __meminit vmemmap_populate_compound_pages(unsigned long start_pfn,
>
> size = min(end - start, pgmap_vmemmap_nr(pgmap) * sizeof(struct page));
> for (addr = start; addr < end; addr += size) {
> - unsigned long next = addr, last = addr + size;
> + unsigned long next, last = addr + size;
>
> /* Populate the head page vmemmap page */
> pte = vmemmap_populate_address(addr, node, NULL, NULL);


--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2022-06-13 20:35    [W:0.068 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site