Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v2] cpu/hotplug: Do not bail-out in DYING/STARTING sections | Date | Mon, 13 Jun 2022 14:36:18 +0200 |
| |
Vincent,
On Mon, May 23 2022 at 17:05, Vincent Donnefort wrote: > +static int _cpuhp_invoke_callback_range(bool bringup, > + unsigned int cpu, > + struct cpuhp_cpu_state *st, > + enum cpuhp_state target, > + bool nofail) > { > enum cpuhp_state state; > - int err = 0; > + int ret = 0; > > while (cpuhp_next_state(bringup, &state, st, target)) { > + int err; > + > err = cpuhp_invoke_callback(cpu, state, bringup, NULL, NULL); > - if (err) > + if (!err) > + continue; > + > + if (nofail) { > + pr_warn("CPU %u %s state %s (%d) failed (%d)\n", > + cpu, bringup ? "UP" : "DOWN", > + cpuhp_get_step(st->state)->name, > + st->state, err); > + ret = -1;
I have a hard time to map this to the changelog:
> those sections. In that case, there's nothing the hotplug machinery can do, > so let's just proceed and log the failures.
That's still returning an error code at the end. Confused.
Thanks,
tglx
| |