lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] certs: move scripts/check-blacklist-hashes.awk to certs/


On 11/06/2022 19:22, Masahiro Yamada wrote:
> This script is only used in certs/Makefile, so certs/ is a better
> home for it.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> MAINTAINERS | 1 -
> certs/Makefile | 2 +-
> {scripts => certs}/check-blacklist-hashes.awk | 0
> 3 files changed, 1 insertion(+), 2 deletions(-)
> rename {scripts => certs}/check-blacklist-hashes.awk (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1fc9ead83d2a..7c2a7c304824 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4627,7 +4627,6 @@ L: keyrings@vger.kernel.org
> S: Maintained
> F: Documentation/admin-guide/module-signing.rst
> F: certs/
> -F: scripts/check-blacklist-hashes.awk > F: scripts/sign-file.c
> F: tools/certs/
>
> diff --git a/certs/Makefile b/certs/Makefile
> index a8d628fd5f7b..df7aaeafd19c 100644
> --- a/certs/Makefile
> +++ b/certs/Makefile
> @@ -13,7 +13,7 @@ CFLAGS_blacklist_hashes.o := -I $(obj)
>
> quiet_cmd_check_and_copy_blacklist_hash_list = GEN $@
> cmd_check_and_copy_blacklist_hash_list = \
> - $(AWK) -f $(srctree)/scripts/check-blacklist-hashes.awk $(CONFIG_SYSTEM_BLACKLIST_HASH_LIST) >&2; \
> + $(AWK) -f $(srctree)/$(src)/check-blacklist-hashes.awk $(CONFIG_SYSTEM_BLACKLIST_HASH_LIST) >&2; \
> cat $(CONFIG_SYSTEM_BLACKLIST_HASH_LIST) > $@
>
> $(obj)/blacklist_hash_list: $(CONFIG_SYSTEM_BLACKLIST_HASH_LIST) FORCE
> diff --git a/scripts/check-blacklist-hashes.awk b/certs/check-blacklist-hashes.awk
> similarity index 100%
> rename from scripts/check-blacklist-hashes.awk
> rename to certs/check-blacklist-hashes.awk

It looks more appropriate and consistent to me to keep it in scripts/,
close to other cert scripts. Is there some precedent to move such script?

\
 
 \ /
  Last update: 2022-06-13 17:19    [W:0.167 / U:1.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site