lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 270/298] mmc: block: Fix CQE recovery reset success
    Date
    From: Adrian Hunter <adrian.hunter@intel.com>

    commit a051246b786af7e4a9d9219cc7038a6e8a411531 upstream.

    The intention of the use of mmc_blk_reset_success() in
    mmc_blk_cqe_recovery() was to prevent repeated resets when retrying and
    getting the same error. However, that may not be the case - any amount
    of time and I/O may pass before another recovery is needed, in which
    case there would be no reason to deny it the opportunity to recover via
    a reset if necessary. CQE recovery is expected seldom and failure to
    recover (if the clear tasks command fails), even more seldom, so it is
    better to allow the reset always, which can be done by calling
    mmc_blk_reset_success() always.

    Fixes: 1e8e55b67030c6 ("mmc: block: Add CQE support")
    Cc: stable@vger.kernel.org
    Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
    Link: https://lore.kernel.org/r/20220531171922.76080-1-adrian.hunter@intel.com
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/mmc/core/block.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/mmc/core/block.c
    +++ b/drivers/mmc/core/block.c
    @@ -1482,8 +1482,7 @@ void mmc_blk_cqe_recovery(struct mmc_que
    err = mmc_cqe_recovery(host);
    if (err)
    mmc_blk_reset(mq->blkdata, host, MMC_BLK_CQE_RECOVERY);
    - else
    - mmc_blk_reset_success(mq->blkdata, MMC_BLK_CQE_RECOVERY);
    + mmc_blk_reset_success(mq->blkdata, MMC_BLK_CQE_RECOVERY);

    pr_debug("%s: CQE recovery done\n", mmc_hostname(host));
    }

    \
     
     \ /
      Last update: 2022-06-13 16:52    [W:4.264 / U:0.800 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site