lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 255/298] platform/x86: hp-wmi: Fix hp_wmi_read_int() reporting error (0x05)
    Date
    From: Jorge Lopez <jorge.lopez2@hp.com>

    [ Upstream commit 12b19f14a21a2ee6348825d95b642ef2cd16794f ]

    The purpose of this patch is to introduce a fix to hp_wmi_read_int()
    and eliminate failure error (0x05). Several WMI queries leverage
    hp_wmi_read_int() to read their data and were failing with error 0x05.

    HPWMI_DISPLAY_QUERY
    HPWMI_HDDTEMP_QUERY
    HPWMI_ALS_QUERY
    HPWMI_HARDWARE_QUERY
    HPWMI_WIRELESS_QUERY
    HPWMI_POSTCODEERROR_QUERY

    The failure occurs because hp_wmi_read_int() calls
    hp_wmi_perform_query() with input parameter of size greater than zero.
    Invoking those WMI commands with an input buffer size greater than
    zero causes the command to be rejected and error 0x05 be returned.

    All changes were validated on a HP ZBook Workstation notebook,
    HP EliteBook x360, and HP EliteBook 850 G8.

    Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com>
    Link: https://lore.kernel.org/r/20220310210853.28367-2-jorge.lopez2@hp.com
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/platform/x86/hp-wmi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
    index 88f0bfd6ecf1..29ae35d15a41 100644
    --- a/drivers/platform/x86/hp-wmi.c
    +++ b/drivers/platform/x86/hp-wmi.c
    @@ -347,7 +347,7 @@ static int hp_wmi_read_int(int query)
    int val = 0, ret;

    ret = hp_wmi_perform_query(query, HPWMI_READ, &val,
    - sizeof(val), sizeof(val));
    + 0, sizeof(val));

    if (ret)
    return ret < 0 ? ret : -EINVAL;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 16:48    [W:4.490 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site