lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 264/298] cifs: populate empty hostnames for extra channels
    Date
    From: Shyam Prasad N <sprasad@microsoft.com>

    commit 4c14d7043fede258957d7b01da0cad2d9fe3a205 upstream.

    Currently, the secondary channels of a multichannel session
    also get hostname populated based on the info in primary channel.
    However, this will end up with a wrong resolution of hostname to
    IP address during reconnect.

    This change fixes this by not populating hostname info for all
    secondary channels.

    Fixes: 5112d80c162f ("cifs: populate server_hostname for extra channels")
    Cc: stable@vger.kernel.org
    Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/cifs/connect.c | 4 ++++
    fs/cifs/sess.c | 5 ++++-
    2 files changed, 8 insertions(+), 1 deletion(-)

    --- a/fs/cifs/connect.c
    +++ b/fs/cifs/connect.c
    @@ -97,6 +97,10 @@ static int reconn_set_ipaddr_from_hostna
    if (!server->hostname)
    return -EINVAL;

    + /* if server hostname isn't populated, there's nothing to do here */
    + if (server->hostname[0] == '\0')
    + return 0;
    +
    len = strlen(server->hostname) + 3;

    unc = kmalloc(len, GFP_KERNEL);
    --- a/fs/cifs/sess.c
    +++ b/fs/cifs/sess.c
    @@ -274,7 +274,10 @@ cifs_ses_add_channel(struct cifs_sb_info
    /* Auth */
    ctx.domainauto = ses->domainAuto;
    ctx.domainname = ses->domainName;
    - ctx.server_hostname = ses->server->hostname;
    +
    + /* no hostname for extra channels */
    + ctx.server_hostname = "";
    +
    ctx.username = ses->user_name;
    ctx.password = ses->password;
    ctx.sectype = ses->sectype;

    \
     
     \ /
      Last update: 2022-06-13 16:48    [W:4.029 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site