lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 253/298] platform/x86: barco-p50-gpio: Add check for platform_driver_register
    Date
    From: Jiasheng Jiang <jiasheng@iscas.ac.cn>

    [ Upstream commit 011881b80ebe773914b59905bce0f5e0ef93e7ba ]

    As platform_driver_register() could fail, it should be better
    to deal with the return value in order to maintain the code
    consisitency.

    Fixes: 86af1d02d458 ("platform/x86: Support for EC-connected GPIOs for identify LED/button on Barco P50 board")
    Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
    Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
    Link: https://lore.kernel.org/r/20220526090345.1444172-1-jiasheng@iscas.ac.cn
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/platform/x86/barco-p50-gpio.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
    index f5c72e33f9ae..f8b796820ef4 100644
    --- a/drivers/platform/x86/barco-p50-gpio.c
    +++ b/drivers/platform/x86/barco-p50-gpio.c
    @@ -406,11 +406,14 @@ MODULE_DEVICE_TABLE(dmi, dmi_ids);
    static int __init p50_module_init(void)
    {
    struct resource res = DEFINE_RES_IO(P50_GPIO_IO_PORT_BASE, P50_PORT_CMD + 1);
    + int ret;

    if (!dmi_first_match(dmi_ids))
    return -ENODEV;

    - platform_driver_register(&p50_gpio_driver);
    + ret = platform_driver_register(&p50_gpio_driver);
    + if (ret)
    + return ret;

    gpio_pdev = platform_device_register_simple(DRIVER_NAME, PLATFORM_DEVID_NONE, &res, 1);
    if (IS_ERR(gpio_pdev)) {
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 16:48    [W:3.042 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site