lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 216/298] misc: rtsx: set NULL intfdata when probe fails
    Date
    From: Shuah Khan <skhan@linuxfoundation.org>

    [ Upstream commit f861d36e021e1ac4a0a2a1f6411d623809975d63 ]

    rtsx_usb_probe() doesn't call usb_set_intfdata() to null out the
    interface pointer when probe fails. This leaves a stale pointer.
    Noticed the missing usb_set_intfdata() while debugging an unrelated
    invalid DMA mapping problem.

    Fix it with a call to usb_set_intfdata(..., NULL).

    Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
    Link: https://lore.kernel.org/r/20220429210913.46804-1-skhan@linuxfoundation.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/misc/cardreader/rtsx_usb.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/misc/cardreader/rtsx_usb.c b/drivers/misc/cardreader/rtsx_usb.c
    index 59eda55d92a3..1ef9b61077c4 100644
    --- a/drivers/misc/cardreader/rtsx_usb.c
    +++ b/drivers/misc/cardreader/rtsx_usb.c
    @@ -667,6 +667,7 @@ static int rtsx_usb_probe(struct usb_interface *intf,
    return 0;

    out_init_fail:
    + usb_set_intfdata(ucr->pusb_intf, NULL);
    usb_free_coherent(ucr->pusb_dev, IOBUF_SIZE, ucr->iobuf,
    ucr->iobuf_dma);
    return ret;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 16:38    [W:4.074 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site