lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 142/298] iommu/arm-smmu-v3: check return value after calling platform_get_resource()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit b131fa8c1d2afd05d0b7598621114674289c2fbb ]

    It will cause null-ptr-deref if platform_get_resource() returns NULL,
    we need check the return value.

    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Link: https://lore.kernel.org/r/20220425114525.2651143-1-yangyingliang@huawei.com
    Signed-off-by: Will Deacon <will@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
    index f60381cdf1c4..a009a3dd762b 100644
    --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
    +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
    @@ -3780,6 +3780,8 @@ static int arm_smmu_device_probe(struct platform_device *pdev)

    /* Base address */
    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    + if (!res)
    + return -EINVAL;
    if (resource_size(res) < arm_smmu_resource_size(smmu)) {
    dev_err(dev, "MMIO region too small (%pr)\n", res);
    return -EINVAL;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 16:32    [W:4.068 / U:0.652 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site