lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 060/298] serial: digicolor-usart: Dont allow CS5-6
    Date
    From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

    [ Upstream commit fd63031b8c0763addcecdefe0e0c59d49646204e ]

    Only CS7 and CS8 seem supported but CSIZE is not sanitized to CS8 in
    the default: block.

    Set CSIZE correctly so that userspace knows the effective value.
    Incorrect CSIZE also results in miscalculation of the frame bits in
    tty_get_char_size() or in its predecessor where the roughly the same
    code is directly within uart_update_timeout().

    Fixes: 5930cb3511df (serial: driver for Conexant Digicolor USART)
    Acked-by: Baruch Siach <baruch@tkos.co.il>
    Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
    Link: https://lore.kernel.org/r/20220519081808.3776-3-ilpo.jarvinen@linux.intel.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/serial/digicolor-usart.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/tty/serial/digicolor-usart.c b/drivers/tty/serial/digicolor-usart.c
    index c7f81aa1ce91..5fea9bf86e85 100644
    --- a/drivers/tty/serial/digicolor-usart.c
    +++ b/drivers/tty/serial/digicolor-usart.c
    @@ -309,6 +309,8 @@ static void digicolor_uart_set_termios(struct uart_port *port,
    case CS8:
    default:
    config |= UA_CONFIG_CHAR_LEN;
    + termios->c_cflag &= ~CSIZE;
    + termios->c_cflag |= CS8;
    break;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 16:23    [W:4.058 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site