lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 067/298] firmware: dmi-sysfs: Fix memory leak in dmi_sysfs_register_handle
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 660ba678f9998aca6db74f2dd912fa5124f0fa31 ]

    kobject_init_and_add() takes reference even when it fails.
    According to the doc of kobject_init_and_add()

    If this function returns an error, kobject_put() must be called to
    properly clean up the memory associated with the object.

    Fix this issue by calling kobject_put().

    Fixes: 948af1f0bbc8 ("firmware: Basic dmi-sysfs support")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220511071421.9769-1-linmq006@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/firmware/dmi-sysfs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/firmware/dmi-sysfs.c b/drivers/firmware/dmi-sysfs.c
    index 3a353776bd34..66727ad3361b 100644
    --- a/drivers/firmware/dmi-sysfs.c
    +++ b/drivers/firmware/dmi-sysfs.c
    @@ -604,7 +604,7 @@ static void __init dmi_sysfs_register_handle(const struct dmi_header *dh,
    "%d-%d", dh->type, entry->instance);

    if (*ret) {
    - kfree(entry);
    + kobject_put(&entry->kobj);
    return;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 16:22    [W:4.028 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site