lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 050/298] soc: rockchip: Fix refcount leak in rockchip_grf_init
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 9b59588d8be91c96bfb0371e912ceb4f16315dbf ]

    of_find_matching_node_and_match returns a node pointer with refcount
    incremented, we should use of_node_put() on it when done.
    Add missing of_node_put() to avoid refcount leak.

    Fixes: 4c58063d4258 ("soc: rockchip: add driver handling grf setup")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220516072013.19731-1-linmq006@gmail.com
    Signed-off-by: Heiko Stuebner <heiko@sntech.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/rockchip/grf.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/soc/rockchip/grf.c b/drivers/soc/rockchip/grf.c
    index 494cf2b5bf7b..343ff61ccccb 100644
    --- a/drivers/soc/rockchip/grf.c
    +++ b/drivers/soc/rockchip/grf.c
    @@ -148,12 +148,14 @@ static int __init rockchip_grf_init(void)
    return -ENODEV;
    if (!match || !match->data) {
    pr_err("%s: missing grf data\n", __func__);
    + of_node_put(np);
    return -EINVAL;
    }

    grf_info = match->data;

    grf = syscon_node_to_regmap(np);
    + of_node_put(np);
    if (IS_ERR(grf)) {
    pr_err("%s: could not get grf syscon\n", __func__);
    return PTR_ERR(grf);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 16:17    [W:4.146 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site