lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 017/298] staging: fieldbus: Fix the error handling path in anybuss_host_common_probe()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 7079b3483a17be2cfba64cbd4feb1b7ae07f1ea7 ]

    If device_register() fails, device_unregister() should not be called
    because it will free some resources that are not allocated.
    put_device() should be used instead.

    Fixes: 308ee87a2f1e ("staging: fieldbus: anybus-s: support HMS Anybus-S bus")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Link: https://lore.kernel.org/r/5401a519608d6e1a4e7435c20f4f20b0c5c36c23.1650610082.git.christophe.jaillet@wanadoo.fr
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/fieldbus/anybuss/host.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/staging/fieldbus/anybuss/host.c b/drivers/staging/fieldbus/anybuss/host.c
    index a344410e48fe..cd86b9c9e345 100644
    --- a/drivers/staging/fieldbus/anybuss/host.c
    +++ b/drivers/staging/fieldbus/anybuss/host.c
    @@ -1384,7 +1384,7 @@ anybuss_host_common_probe(struct device *dev,
    goto err_device;
    return cd;
    err_device:
    - device_unregister(&cd->client->dev);
    + put_device(&cd->client->dev);
    err_kthread:
    kthread_stop(cd->qthread);
    err_reset:
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 16:17    [W:5.018 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site