lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 007/298] tty: serial: owl: Fix missing clk_disable_unprepare() in owl_uart_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit bcea0f547ec1a2ee44d429aaf0334633e386e67c ]

    Fix the missing clk_disable_unprepare() before return
    from owl_uart_probe() in the error handling case.

    Fixes: abf42d2f333b ("tty: serial: owl: add "much needed" clk_prepare_enable()")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220307105135.11698-1-linmq006@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/serial/owl-uart.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/tty/serial/owl-uart.c b/drivers/tty/serial/owl-uart.c
    index 91f1eb0058d7..9a6611cfc18e 100644
    --- a/drivers/tty/serial/owl-uart.c
    +++ b/drivers/tty/serial/owl-uart.c
    @@ -731,6 +731,7 @@ static int owl_uart_probe(struct platform_device *pdev)
    owl_port->port.uartclk = clk_get_rate(owl_port->clk);
    if (owl_port->port.uartclk == 0) {
    dev_err(&pdev->dev, "clock rate is zero\n");
    + clk_disable_unprepare(owl_port->clk);
    return -EINVAL;
    }
    owl_port->port.flags = UPF_BOOT_AUTOCONF | UPF_IOREMAP | UPF_LOW_LATENCY;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 16:13    [W:4.031 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site