lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.17 002/298] staging: greybus: codecs: fix type confusion of list iterator variable
    Date
    From: Jakob Koschel <jakobkoschel@gmail.com>

    [ Upstream commit 84ef256550196bc06e6849a34224c998b45bd557 ]

    If the list does not exit early then data == NULL and 'module' does not
    point to a valid list element.
    Using 'module' in such a case is not valid and was therefore removed.

    Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver registration")
    Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
    Reviewed-by: Mark Greer <mgreer@animalcreek.com>
    Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
    Link: https://lore.kernel.org/r/20220321123626.3068639-1-jakobkoschel@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/greybus/audio_codec.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
    index b589cf6b1d03..e19b91e7a72e 100644
    --- a/drivers/staging/greybus/audio_codec.c
    +++ b/drivers/staging/greybus/audio_codec.c
    @@ -599,8 +599,8 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
    break;
    }
    if (!data) {
    - dev_err(dai->dev, "%s:%s DATA connection missing\n",
    - dai->name, module->name);
    + dev_err(dai->dev, "%s DATA connection missing\n",
    + dai->name);
    mutex_unlock(&codec->lock);
    return -ENODEV;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 16:12    [W:5.968 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site