lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 301/339] scsi: sd: Fix interpretation of VPD B9h length
    Date
    From: Tyler Erickson <tyler.erickson@seagate.com>

    commit f92de9d110429e39929a49240d823251c2fe903e upstream.

    Fixing the interpretation of the length of the B9h VPD page (Concurrent
    Positioning Ranges). Adding 4 is necessary as the first 4 bytes of the page
    is the header with page number and length information. Adding 3 was likely
    a misinterpretation of the SBC-5 specification which sets all offsets
    starting at zero.

    This fixes the error in dmesg:

    [ 9.014456] sd 1:0:0:0: [sda] Invalid Concurrent Positioning Ranges VPD page

    Link: https://lore.kernel.org/r/20220602225113.10218-4-tyler.erickson@seagate.com
    Fixes: e815d36548f0 ("scsi: sd: add concurrent positioning ranges support")
    Cc: stable@vger.kernel.org
    Tested-by: Michael English <michael.english@seagate.com>
    Reviewed-by: Muhammad Ahmad <muhammad.ahmad@seagate.com>
    Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
    Reviewed-by: Hannes Reinecke <hare@suse.de>
    Signed-off-by: Tyler Erickson <tyler.erickson@seagate.com>
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/scsi/sd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/scsi/sd.c
    +++ b/drivers/scsi/sd.c
    @@ -3067,7 +3067,7 @@ static void sd_read_cpr(struct scsi_disk
    goto out;

    /* We must have at least a 64B header and one 32B range descriptor */
    - vpd_len = get_unaligned_be16(&buffer[2]) + 3;
    + vpd_len = get_unaligned_be16(&buffer[2]) + 4;
    if (vpd_len > buf_len || vpd_len < 64 + 32 || (vpd_len & 31)) {
    sd_printk(KERN_ERR, sdkp,
    "Invalid Concurrent Positioning Ranges VPD page\n");

    \
     
     \ /
      Last update: 2022-06-13 16:07    [W:4.024 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site