lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 170/339] video: fbdev: hyperv_fb: Allow resolutions with size > 64 MB for Gen1
    Date
    From: Saurabh Sengar <ssengar@linux.microsoft.com>

    [ Upstream commit c4b4d7047f16a8d138ce76da65faefb7165736f2 ]

    This patch fixes a bug where GEN1 VMs doesn't allow resolutions greater
    than 64 MB size (eg 7680x4320). Unnecessary PCI check limits Gen1 VRAM
    to legacy PCI BAR size only (ie 64MB). Thus any, resolution requesting
    greater then 64MB (eg 7680x4320) would fail. MMIO region assigning this
    memory shouldn't be limited by PCI bar size.

    Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
    Reviewed-by: Dexuan Cui <decui@microsoft.com>
    Signed-off-by: Helge Deller <deller@gmx.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/video/fbdev/hyperv_fb.c | 19 +------------------
    1 file changed, 1 insertion(+), 18 deletions(-)

    diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
    index c8e0ea27caf1..58c304a3b7c4 100644
    --- a/drivers/video/fbdev/hyperv_fb.c
    +++ b/drivers/video/fbdev/hyperv_fb.c
    @@ -1009,7 +1009,6 @@ static int hvfb_getmem(struct hv_device *hdev, struct fb_info *info)
    struct pci_dev *pdev = NULL;
    void __iomem *fb_virt;
    int gen2vm = efi_enabled(EFI_BOOT);
    - resource_size_t pot_start, pot_end;
    phys_addr_t paddr;
    int ret;

    @@ -1060,23 +1059,7 @@ static int hvfb_getmem(struct hv_device *hdev, struct fb_info *info)
    dio_fb_size =
    screen_width * screen_height * screen_depth / 8;

    - if (gen2vm) {
    - pot_start = 0;
    - pot_end = -1;
    - } else {
    - if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM) ||
    - pci_resource_len(pdev, 0) < screen_fb_size) {
    - pr_err("Resource not available or (0x%lx < 0x%lx)\n",
    - (unsigned long) pci_resource_len(pdev, 0),
    - (unsigned long) screen_fb_size);
    - goto err1;
    - }
    -
    - pot_end = pci_resource_end(pdev, 0);
    - pot_start = pot_end - screen_fb_size + 1;
    - }
    -
    - ret = vmbus_allocate_mmio(&par->mem, hdev, pot_start, pot_end,
    + ret = vmbus_allocate_mmio(&par->mem, hdev, 0, -1,
    screen_fb_size, 0x100000, true);
    if (ret != 0) {
    pr_err("Unable to allocate framebuffer memory\n");
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 15:50    [W:4.186 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site