lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 117/339] sched/autogroup: Fix sysctl move
    Date
    From: Peter Zijlstra <peterz@infradead.org>

    [ Upstream commit 82f586f923e3ac6062bc7867717a7f8afc09e0ff ]

    Ivan reported /proc/sys/kernel/sched_autogroup_enabled went walk-about
    and using the noautogroup command line parameter would result in a
    boot error message.

    Turns out the sysctl move placed the init function wrong.

    Fixes: c8eaf6ac76f4 ("sched: move autogroup sysctls into its own file")
    Reported-by: Ivan Kozik <ivan@ludios.org>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Tested-by: Ivan Kozik <ivan@ludios.org>
    Link: https://lkml.kernel.org/r/YpR2IqndgsyMzN00@worktop.programming.kicks-ass.net
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/sched/autogroup.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/sched/autogroup.c b/kernel/sched/autogroup.c
    index 16092b49ff6a..4ebaf97f7bd8 100644
    --- a/kernel/sched/autogroup.c
    +++ b/kernel/sched/autogroup.c
    @@ -36,6 +36,7 @@ void __init autogroup_init(struct task_struct *init_task)
    kref_init(&autogroup_default.kref);
    init_rwsem(&autogroup_default.lock);
    init_task->signal->autogroup = &autogroup_default;
    + sched_autogroup_sysctl_init();
    }

    void autogroup_free(struct task_group *tg)
    @@ -219,7 +220,6 @@ void sched_autogroup_exit(struct signal_struct *sig)
    static int __init setup_autogroup(char *str)
    {
    sysctl_sched_autogroup_enabled = 0;
    - sched_autogroup_sysctl_init();

    return 1;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 15:47    [W:4.723 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site