lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 132/339] vdpa: ifcvf: set pci driver data in probe
    Date
    From: Jason Wang <jasowang@redhat.com>

    [ Upstream commit bd8bb9aed56b1814784a975e2dfea12a9adcee92 ]

    We should set the pci driver data in probe instead of the vdpa device
    adding callback. Otherwise if no vDPA device is created we will lose
    the pointer to the management device.

    Fixes: 6b5df347c6482 ("vDPA/ifcvf: implement management netlink framework for ifcvf")
    Tested-by: Zheyu Ma <zheyuma97@gmail.com>
    Signed-off-by: Jason Wang <jasowang@redhat.com>
    Message-Id: <20220524055557.1938-1-jasowang@redhat.com>
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/vdpa/ifcvf/ifcvf_main.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
    index 4366320fb68d..197d52e7b801 100644
    --- a/drivers/vdpa/ifcvf/ifcvf_main.c
    +++ b/drivers/vdpa/ifcvf/ifcvf_main.c
    @@ -765,7 +765,6 @@ static int ifcvf_vdpa_dev_add(struct vdpa_mgmt_dev *mdev, const char *name,
    }

    ifcvf_mgmt_dev->adapter = adapter;
    - pci_set_drvdata(pdev, ifcvf_mgmt_dev);

    vf = &adapter->vf;
    vf->dev_type = get_dev_type(pdev);
    @@ -880,6 +879,8 @@ static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id)
    goto err;
    }

    + pci_set_drvdata(pdev, ifcvf_mgmt_dev);
    +
    return 0;

    err:
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 15:47    [W:2.798 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site