Messages in this thread |  | | Date | Mon, 13 Jun 2022 10:12:06 +0200 | Subject | Re: [PATCH v2 000/144] KVM: selftests: Overhaul APIs, purge VCPU_ID | From | Thomas Huth <> |
| |
On 10/06/2022 02.57, Sean Christopherson wrote: > +s390 folks... > > On Fri, Jun 10, 2022, Sean Christopherson wrote: >> On Thu, Jun 09, 2022, Sean Christopherson wrote: >>> On Thu, Jun 09, 2022, Anup Patel wrote: >>>> On Wed, Jun 8, 2022 at 9:26 PM Anup Patel <anup@brainfault.org> wrote: >>>>> >>>>> On Tue, Jun 7, 2022 at 8:57 PM Paolo Bonzini <pbonzini@redhat.com> wrote: >>>>>> >>>>>> Marc, Christian, Anup, can you please give this a go? >>>>> >>>>> Sure, I will try this series. >>>> >>>> I tried to apply this series on top of kvm/next and kvm/queue but >>>> I always get conflicts. It seems this series is dependent on other >>>> in-flight patches. >>> >>> Hrm, that's odd, it's based directly on kvm/queue, commit 55371f1d0c01 ("KVM: ...). >> >> Duh, Paolo updated kvm/queue. Where's Captain Obvious when you need him... >> >>>> Is there a branch somewhere in a public repo ? >>> >>> https://github.com/sean-jc/linux/tree/x86/selftests_overhaul >> >> I pushed a new version that's based on the current kvm/queue, commit 5e9402ac128b. >> arm and x86 look good (though I've yet to test on AMD). >> >> Thomas, >> If you get a chance, could you rerun the s390 tests? The recent refactorings to >> use TAP generated some fun conflicts.
Still works fine! Tested-by: Thomas Huth <thuth@redhat.com>
>> Speaking of TAP, I added a patch to convert __TEST_REQUIRE to use ksft_exit_skip() >> instead of KVM's custom print_skip(). The s390 tests are being converted to use >> TAP output, I couldn't see any advantage of KVM's arbitrary "skipping test" over >> TAP-friendly output, and converting everything is far easier than special casing s390.
Sounds like a good idea to me. I already considered starting to convert some x86 tests, too (https://lore.kernel.org/linux-kselftest/20220429071149.488114-1-thuth@redhat.com ), but didn't get much feedback there yet, but anyway, we'll be better prepared with your change for that now.
Thomas
|  |