lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 088/339] net: ethernet: ti: am65-cpsw: Fix fwnode passed to phylink_create()
    Date
    From: Siddharth Vadapalli <s-vadapalli@ti.com>

    [ Upstream commit 0b7180072a9df5e18af5b58410fec38230848a8d ]

    am65-cpsw-nuss driver incorrectly uses fwnode member of common
    ethernet device's "struct device_node" instead of using fwnode
    member of the port's "struct device_node" in phylink_create().
    This results in all ports having the same phy data when there
    are multiple ports with their phy properties populated in their
    respective nodes rather than the common ethernet device node.

    Fix it here by using fwnode member of the port's node.

    Fixes: e8609e69470f ("net: ethernet: ti: am65-cpsw: Convert to PHYLINK")
    Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
    Link: https://lore.kernel.org/r/20220524062558.19296-1-s-vadapalli@ti.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/ti/am65-cpsw-nuss.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
    index d2747e9db286..98969070ed4b 100644
    --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
    +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
    @@ -9,6 +9,7 @@
    #include <linux/etherdevice.h>
    #include <linux/if_vlan.h>
    #include <linux/interrupt.h>
    +#include <linux/irqdomain.h>
    #include <linux/kernel.h>
    #include <linux/kmemleak.h>
    #include <linux/module.h>
    @@ -1989,7 +1990,9 @@ am65_cpsw_nuss_init_port_ndev(struct am65_cpsw_common *common, u32 port_idx)

    phy_interface_set_rgmii(port->slave.phylink_config.supported_interfaces);

    - phylink = phylink_create(&port->slave.phylink_config, dev->fwnode, port->slave.phy_if,
    + phylink = phylink_create(&port->slave.phylink_config,
    + of_node_to_fwnode(port->slave.phy_node),
    + port->slave.phy_if,
    &am65_cpsw_phylink_mac_ops);
    if (IS_ERR(phylink))
    return PTR_ERR(phylink);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 15:42    [W:4.021 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site