lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 038/339] rpmsg: qcom_smd: Fix returning 0 if irq_of_parse_and_map() fails
    Date
    From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

    [ Upstream commit 59d6f72f6f9c92fec8757d9e29527da828e9281f ]

    irq_of_parse_and_map() returns 0 on failure, so this should not be
    passed further as error return code.

    Fixes: 1a358d350664 ("rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value")
    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Link: https://lore.kernel.org/r/20220423093932.32136-1-krzysztof.kozlowski@linaro.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/rpmsg/qcom_smd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
    index 6ccfa12abd10..1957b27c4cf3 100644
    --- a/drivers/rpmsg/qcom_smd.c
    +++ b/drivers/rpmsg/qcom_smd.c
    @@ -1409,7 +1409,7 @@ static int qcom_smd_parse_edge(struct device *dev,
    irq = irq_of_parse_and_map(node, 0);
    if (!irq) {
    dev_err(dev, "required smd interrupt missing\n");
    - ret = irq;
    + ret = -EINVAL;
    goto put_node;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 15:37    [W:3.308 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site