lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 004/339] soundwire: qcom: fix an error message in swrm_wait_for_frame_gen_enabled()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit d146de3430d2b21054f6dc8a890f84062515f4d2 ]

    The logical AND && is supposed to be bitwise AND & so it will sometimes
    print "connected" instead of "disconnected".

    Fixes: 74e79da9fd46 ("soundwire: qcom: add runtime pm support")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Link: https://lore.kernel.org/r/20220307125814.GD16710@kili
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soundwire/qcom.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
    index da1ad7ebb1aa..dd9f67f895b2 100644
    --- a/drivers/soundwire/qcom.c
    +++ b/drivers/soundwire/qcom.c
    @@ -1452,7 +1452,7 @@ static bool swrm_wait_for_frame_gen_enabled(struct qcom_swrm_ctrl *swrm)
    } while (retry--);

    dev_err(swrm->dev, "%s: link status not %s\n", __func__,
    - comp_sts && SWRM_FRM_GEN_ENABLED ? "connected" : "disconnected");
    + comp_sts & SWRM_FRM_GEN_ENABLED ? "connected" : "disconnected");

    return false;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 15:27    [W:4.089 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site