lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/6] mm: hugetlb_vmemmap: delete hugetlb_optimize_vmemmap_enabled()
    On Mon, Jun 13, 2022 at 02:35:07PM +0800, Muchun Song wrote:
    > The name hugetlb_optimize_vmemmap_enabled() a bit confusing as it tests
    > two conditions (enabled and pages in use). Instead of coming up to
    > an appropriate name, we could just delete it. There is already a
    > discussion about deleting it in thread [1].
    >
    > There is only one user of hugetlb_optimize_vmemmap_enabled() outside of
    > hugetlb_vmemmap, that is flush_dcache_page() in arch/arm64/mm/flush.c.
    > However, it does not need to call hugetlb_optimize_vmemmap_enabled()
    > in flush_dcache_page() since HugeTLB pages are always fully mapped and
    > only head page will be set PG_dcache_clean meaning only head page's flag
    > may need to be cleared (see commit cf5a501d985b). So it is easy to
    > remove hugetlb_optimize_vmemmap_enabled().
    >
    > Link: https://lore.kernel.org/all/c77c61c8-8a5a-87e8-db89-d04d8aaab4cc@oracle.com/ [1]
    > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
    > Cc: Catalin Marinas <catalin.marinas@arm.com>
    > Cc: Will Deacon <will@kernel.org>
    > Cc: Anshuman Khandual <anshuman.khandual@arm.com>

    Reviewed-by: Oscar Salvador <osalvador@suse.de>


    --
    Oscar Salvador
    SUSE Labs

    \
     
     \ /
      Last update: 2022-06-13 10:05    [W:4.213 / U:0.608 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site