lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 042/247] extcon: ptn5150: Add queue work sync before driver release
    Date
    From: Li Jun <jun.li@nxp.com>

    [ Upstream commit 782cd939cbe0f569197cd1c9b0477ee213167f04 ]

    Add device managed action to sync pending queue work, otherwise
    the queued work may run after the work is destroyed.

    Fixes: 4ed754de2d66 ("extcon: Add support for ptn5150 extcon driver")
    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    Signed-off-by: Li Jun <jun.li@nxp.com>
    Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/extcon/extcon-ptn5150.c | 11 +++++++++++
    1 file changed, 11 insertions(+)

    diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
    index 5b9a3cf8df26..2a7874108df8 100644
    --- a/drivers/extcon/extcon-ptn5150.c
    +++ b/drivers/extcon/extcon-ptn5150.c
    @@ -194,6 +194,13 @@ static int ptn5150_init_dev_type(struct ptn5150_info *info)
    return 0;
    }

    +static void ptn5150_work_sync_and_put(void *data)
    +{
    + struct ptn5150_info *info = data;
    +
    + cancel_work_sync(&info->irq_work);
    +}
    +
    static int ptn5150_i2c_probe(struct i2c_client *i2c)
    {
    struct device *dev = &i2c->dev;
    @@ -284,6 +291,10 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c)
    if (ret)
    return -EINVAL;

    + ret = devm_add_action_or_reset(dev, ptn5150_work_sync_and_put, info);
    + if (ret)
    + return ret;
    +
    /*
    * Update current extcon state if for example OTG connection was there
    * before the probe
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 15:01    [W:4.095 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site