lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 036/172] serial: txx9: Dont allow CS5-6
    Date
    From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

    [ Upstream commit 79ac88655dc0551e3571ad16bdabdbe65d61553e ]

    Only CS7 and CS8 are supported but CSIZE is not sanitized with
    CS5 or CS6 to CS8.

    Set CSIZE correctly so that userspace knows the effective value.
    Incorrect CSIZE also results in miscalculation of the frame bits in
    tty_get_char_size() or in its predecessor where the roughly the same
    code is directly within uart_update_timeout().

    Fixes: 1da177e4c3f4 (Linux-2.6.12-rc2)
    Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
    Link: https://lore.kernel.org/r/20220519081808.3776-5-ilpo.jarvinen@linux.intel.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/serial/serial_txx9.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/tty/serial/serial_txx9.c b/drivers/tty/serial/serial_txx9.c
    index 7a07e7272de1..7beec331010c 100644
    --- a/drivers/tty/serial/serial_txx9.c
    +++ b/drivers/tty/serial/serial_txx9.c
    @@ -644,6 +644,8 @@ serial_txx9_set_termios(struct uart_port *port, struct ktermios *termios,
    case CS6: /* not supported */
    case CS8:
    cval |= TXX9_SILCR_UMODE_8BIT;
    + termios->c_cflag &= ~CSIZE;
    + termios->c_cflag |= CS8;
    break;
    }

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 14:33    [W:3.028 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site