lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 204/287] rtc: mt6397: check return value after calling platform_get_resource()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit d3b43eb505bffb8e4cdf6800c15660c001553fe6 ]

    It will cause null-ptr-deref if platform_get_resource() returns NULL,
    we need check the return value.

    Fixes: fc2979118f3f ("rtc: mediatek: Add MT6397 RTC driver")
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Link: https://lore.kernel.org/r/20220505125043.1594771-1-yangyingliang@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/rtc/rtc-mt6397.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
    index 964ed91416e1..671b6d275da3 100644
    --- a/drivers/rtc/rtc-mt6397.c
    +++ b/drivers/rtc/rtc-mt6397.c
    @@ -339,6 +339,8 @@ static int mtk_rtc_probe(struct platform_device *pdev)
    return -ENOMEM;

    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    + if (!res)
    + return -EINVAL;
    rtc->addr_base = res->start;

    rtc->irq = platform_get_irq(pdev, 0);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 14:15    [W:2.078 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site