lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 195/287] usb: musb: Fix missing of_node_put() in omap2430_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit 424bef51fa530389b0b9008c9e144e40c10e8458 ]

    The device_node pointer is returned by of_parse_phandle() with refcount
    incremented. We should use of_node_put() on it when done.

    Fixes: 8934d3e4d0e7 ("usb: musb: omap2430: Don't use omap_get_control_dev()")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220309111033.24487-1-linmq006@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/musb/omap2430.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
    index 24e622c05638..5f1c41e95f56 100644
    --- a/drivers/usb/musb/omap2430.c
    +++ b/drivers/usb/musb/omap2430.c
    @@ -433,6 +433,7 @@ static int omap2430_probe(struct platform_device *pdev)
    control_node = of_parse_phandle(np, "ctrl-module", 0);
    if (control_node) {
    control_pdev = of_find_device_by_node(control_node);
    + of_node_put(control_node);
    if (!control_pdev) {
    dev_err(&pdev->dev, "Failed to get control device\n");
    ret = -EINVAL;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 14:06    [W:4.122 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site