lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 124/287] powerpc/4xx/cpm: Fix return value of __setup() handler
    Date
    From: Randy Dunlap <rdunlap@infradead.org>

    [ Upstream commit 5bb99fd4090fe1acfdb90a97993fcda7f8f5a3d6 ]

    __setup() handlers should return 1 to obsolete_checksetup() in
    init/main.c to indicate that the boot option has been handled.

    A return of 0 causes the boot option/value to be listed as an Unknown
    kernel parameter and added to init's (limited) argument or environment
    strings.

    Also, error return codes don't mean anything to obsolete_checksetup() --
    only non-zero (usually 1) or zero. So return 1 from cpm_powersave_off().

    Fixes: d164f6d4f910 ("powerpc/4xx: Add suspend and idle support")
    Reported-by: Igor Zhbanov <izh1979@gmail.com>
    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20220502192941.20955-1-rdunlap@infradead.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/platforms/4xx/cpm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/powerpc/platforms/4xx/cpm.c b/arch/powerpc/platforms/4xx/cpm.c
    index 53ff81ca8a3c..6400ae376216 100644
    --- a/arch/powerpc/platforms/4xx/cpm.c
    +++ b/arch/powerpc/platforms/4xx/cpm.c
    @@ -341,6 +341,6 @@ late_initcall(cpm_init);
    static int __init cpm_powersave_off(char *arg)
    {
    cpm.powersave_off = 1;
    - return 0;
    + return 1;
    }
    __setup("powersave=off", cpm_powersave_off);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 14:03    [W:5.072 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site