Messages in this thread | | | Date | Mon, 13 Jun 2022 16:25:51 +0530 | Subject | Re: [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name | From | Srinivasa Rao Mandadapu <> |
| |
On 6/2/2022 8:10 PM, Mark Brown wrote: Thanks for your time Mark Brown and Rob Herring!!! > On Thu, Jun 02, 2022 at 09:32:45AM -0500, Rob Herring wrote: >> On Thu, Jun 02, 2022 at 04:56:45PM +0530, Srinivasa Rao Mandadapu wrote: >>> Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0", >>> as MI2S mclk is being used is from lpass core cc. >> This is safe to change breaking the ABI because ... > The driver was only just merged so didn't make it into a full > release. yes. DTS changes are still in review state. > >> Names are supposed to be local to the module, not based on their source. > Indeed.
Okay. Will take care next time. As external MCLK is supported from both modules, audio cc and core cc,
for now it's mandatory to change the name to avoid confusion.
| |