lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 372/411] USB: host: isp116x: check return value after calling platform_get_resource()
    Date
    From: Zhen Ni <nizhen@uniontech.com>

    [ Upstream commit 134a3408c2d3f7e23eb0e4556e0a2d9f36c2614e ]

    It will cause null-ptr-deref if platform_get_resource() returns NULL,
    we need check the return value.

    Signed-off-by: Zhen Ni <nizhen@uniontech.com>
    Link: https://lore.kernel.org/r/20220302033716.31272-1-nizhen@uniontech.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/host/isp116x-hcd.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c
    index a87c0b26279e..00a4e12a1f15 100644
    --- a/drivers/usb/host/isp116x-hcd.c
    +++ b/drivers/usb/host/isp116x-hcd.c
    @@ -1541,10 +1541,12 @@ static int isp116x_remove(struct platform_device *pdev)

    iounmap(isp116x->data_reg);
    res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
    - release_mem_region(res->start, 2);
    + if (res)
    + release_mem_region(res->start, 2);
    iounmap(isp116x->addr_reg);
    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    - release_mem_region(res->start, 2);
    + if (res)
    + release_mem_region(res->start, 2);

    usb_put_hcd(hcd);
    return 0;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 13:47    [W:4.052 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site