lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 340/411] f2fs: remove WARN_ON in f2fs_is_valid_blkaddr
    Date
    From: Dongliang Mu <mudongliangabcd@gmail.com>

    [ Upstream commit dc2f78e2d4cc844a1458653d57ce1b54d4a29f21 ]

    Syzbot triggers two WARNs in f2fs_is_valid_blkaddr and
    __is_bitmap_valid. For example, in f2fs_is_valid_blkaddr,
    if type is DATA_GENERIC_ENHANCE or DATA_GENERIC_ENHANCE_READ,
    it invokes WARN_ON if blkaddr is not in the right range.
    The call trace is as follows:

    f2fs_get_node_info+0x45f/0x1070
    read_node_page+0x577/0x1190
    __get_node_page.part.0+0x9e/0x10e0
    __get_node_page
    f2fs_get_node_page+0x109/0x180
    do_read_inode
    f2fs_iget+0x2a5/0x58b0
    f2fs_fill_super+0x3b39/0x7ca0

    Fix these two WARNs by replacing WARN_ON with dump_stack.

    Reported-by: syzbot+763ae12a2ede1d99d4dc@syzkaller.appspotmail.com
    Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
    Reviewed-by: Chao Yu <chao@kernel.org>
    Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/f2fs/checkpoint.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
    index 54f0d2c4c7d8..44c5110e18f0 100644
    --- a/fs/f2fs/checkpoint.c
    +++ b/fs/f2fs/checkpoint.c
    @@ -149,7 +149,7 @@ static bool __is_bitmap_valid(struct f2fs_sb_info *sbi, block_t blkaddr,
    f2fs_err(sbi, "Inconsistent error blkaddr:%u, sit bitmap:%d",
    blkaddr, exist);
    set_sbi_flag(sbi, SBI_NEED_FSCK);
    - WARN_ON(1);
    + dump_stack();
    }
    return exist;
    }
    @@ -187,7 +187,7 @@ bool f2fs_is_valid_blkaddr(struct f2fs_sb_info *sbi,
    f2fs_warn(sbi, "access invalid blkaddr:%u",
    blkaddr);
    set_sbi_flag(sbi, SBI_NEED_FSCK);
    - WARN_ON(1);
    + dump_stack();
    return false;
    } else {
    return __is_bitmap_valid(sbi, blkaddr, type);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 13:42    [W:5.813 / U:0.920 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site