lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 329/411] nfp: only report pause frame configuration for physical device
    Date
    From: Yu Xiao <yu.xiao@corigine.com>

    [ Upstream commit 0649e4d63420ebc8cbebef3e9d39e12ffc5eb9fa ]

    Only report pause frame configuration for physical device. Logical
    port of both PCI PF and PCI VF do not support it.

    Fixes: 9fdc5d85a8fe ("nfp: update ethtool reporting of pauseframe control")
    Signed-off-by: Yu Xiao <yu.xiao@corigine.com>
    Signed-off-by: Simon Horman <simon.horman@corigine.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
    index 89e578e25ff8..10857914c552 100644
    --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
    +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
    @@ -266,8 +266,6 @@ nfp_net_get_link_ksettings(struct net_device *netdev,

    /* Init to unknowns */
    ethtool_link_ksettings_add_link_mode(cmd, supported, FIBRE);
    - ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
    - ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
    cmd->base.port = PORT_OTHER;
    cmd->base.speed = SPEED_UNKNOWN;
    cmd->base.duplex = DUPLEX_UNKNOWN;
    @@ -275,6 +273,8 @@ nfp_net_get_link_ksettings(struct net_device *netdev,
    port = nfp_port_from_netdev(netdev);
    eth_port = nfp_port_get_eth_port(port);
    if (eth_port) {
    + ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
    + ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
    cmd->base.autoneg = eth_port->aneg != NFP_ANEG_DISABLED ?
    AUTONEG_ENABLE : AUTONEG_DISABLE;
    nfp_net_set_fec_link_mode(eth_port, cmd);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 13:41    [W:4.019 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site