lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 294/411] usb: dwc3: pci: Fix pm_runtime_get_sync() error checking
    Date
    From: Zheng Yongjun <zhengyongjun3@huawei.com>

    [ Upstream commit a03e2ddab8e735e2cc315609b297b300e9cc60d2 ]

    If the device is already in a runtime PM enabled state
    pm_runtime_get_sync() will return 1, so a test for negative
    value should be used to check for errors.

    Fixes: 8eed00b237a28 ("usb: dwc3: pci: Runtime resume child device from wq")
    Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
    Link: https://lore.kernel.org/r/20220422062652.10575-1-zhengyongjun3@huawei.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/dwc3/dwc3-pci.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
    index 99964f96ff74..955bf820f410 100644
    --- a/drivers/usb/dwc3/dwc3-pci.c
    +++ b/drivers/usb/dwc3/dwc3-pci.c
    @@ -211,7 +211,7 @@ static void dwc3_pci_resume_work(struct work_struct *work)
    int ret;

    ret = pm_runtime_get_sync(&dwc3->dev);
    - if (ret) {
    + if (ret < 0) {
    pm_runtime_put_sync_autosuspend(&dwc3->dev);
    return;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 13:38    [W:4.119 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site