lkml.org 
[lkml]   [2022]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 199/411] i2c: at91: Initialize dma_buf in at91_twi_xfer()
    Date
    From: Nathan Chancellor <nathan@kernel.org>

    [ Upstream commit 6977262c2eee111645668fe9e235ef2f5694abf7 ]

    Clang warns:

    drivers/i2c/busses/i2c-at91-master.c:707:6: warning: variable 'dma_buf' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
    if (dev->use_dma) {
    ^~~~~~~~~~~~
    drivers/i2c/busses/i2c-at91-master.c:717:27: note: uninitialized use occurs here
    i2c_put_dma_safe_msg_buf(dma_buf, m_start, !ret);
    ^~~~~~~

    Initialize dma_buf to NULL, as i2c_put_dma_safe_msg_buf() is a no-op
    when the first argument is NULL, which will work for the !dev->use_dma
    case.

    Fixes: 03fbb903c8bf ("i2c: at91: use dma safe buffers")
    Link: https://github.com/ClangBuiltLinux/linux/issues/1629
    Signed-off-by: Nathan Chancellor <nathan@kernel.org>
    Reviewed-by: Michael Walle <michael@walle.cc>
    Signed-off-by: Wolfram Sang <wsa@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/i2c/busses/i2c-at91-master.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/i2c/busses/i2c-at91-master.c b/drivers/i2c/busses/i2c-at91-master.c
    index 44502024cc10..f74d5ad2f1fa 100644
    --- a/drivers/i2c/busses/i2c-at91-master.c
    +++ b/drivers/i2c/busses/i2c-at91-master.c
    @@ -609,7 +609,7 @@ static int at91_twi_xfer(struct i2c_adapter *adap, struct i2c_msg *msg, int num)
    unsigned int_addr_flag = 0;
    struct i2c_msg *m_start = msg;
    bool is_read;
    - u8 *dma_buf;
    + u8 *dma_buf = NULL;

    dev_dbg(&adap->dev, "at91_xfer: processing %d messages:\n", num);

    --
    2.35.1


    \
     
     \ /
      Last update: 2022-06-13 13:26    [W:4.039 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site